Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update precision of DATETIME and TIMESTAMP values #13565

Merged
merged 1 commit into from
May 16, 2023
Merged

update precision of DATETIME and TIMESTAMP values #13565

merged 1 commit into from
May 16, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented May 16, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Fix the precision of DATETIME and TIMESTAMP values from milliseconds to microseconds.

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2023
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels May 16, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 16, 2023
Oreoxmt
Oreoxmt approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2023
guangleibao
guangleibao approved these changes May 16, 2023
View reviewed changes
Copy link

@guangleibao guangleibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai
Copy link
Collaborator Author

qiancai commented May 16, 2023

/remove-status LGT1
/status LGT2
/merge

@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2d66dfa

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 126add2 into pingcap:master May 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13566.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13567.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13568.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13569.

ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
update precision of DATETIME and TIMESTAMP values (#13565) (#13569)
9df8ade
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
update precision of DATETIME and TIMESTAMP values (#13565) (#13568)
b9eb289
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
update precision of DATETIME and TIMESTAMP values (#13565) (#13567)
de1d0f2
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
update precision of DATETIME and TIMESTAMP values (#13565) (#13566)
6808b08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@guangleibao guangleibao guangleibao approved these changes

@dulao5 dulao5 dulao5 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiancai @ti-chi-bot @dulao5 @guangleibao @Oreoxmt